Package Exports

eslint-plugin-isaacscript
eslint-plugin-isaacscript/dist/index.js

This package does not declare an exports field, so the exports above have been automatically detected and optimized by JSPM instead. If any package subpath is missing, it is recommended to post an issue to the original package (eslint-plugin-isaacscript) to support the "exports" field. If that is not possible, create a JSPM override to customize the exports field for this package.

Readme

eslint-plugin-isaacscript

eslint-plugin-isaacscript is a collection of miscellaneous ESLint rules that can help make your JavaScript/TypeScript code more safe or more strict.

This plugin is named after (and used in) the IsaacScript framework. But you don't have to know anything about IsaacScript to use it - you can use this plugin with any JavaScript/TypeScript project.

Alternatively, if you want to get off the ground and running with ESLint + TypeScript in a new project, then you should check out the isaacscript-lint meta-package.

This project is written in TypeScript.

Install / Usage

npm install --save-dev eslint eslint-plugin-isaacscript
Add "plugin:isaacscript/recommended" to the extends section of your .eslintrc.js file. (This will automatically add the plugin and add all of the recommended rules.)
- Alternatively, if you want to only enable some specific rules, then add "isaacscript" to the plugins section of your .eslintrc.js file, and then add the specific rules that you want in the rules section.

Configs

recommended - Enables just the recommended rules.
all - Enables all the rules.

Rules

Each rule has emojis denoting:

✅ - if it belongs to the recommended configuration
🔧 - if some problems reported by the rule are automatically fixable by the --fix command line option
💭 - if it requires type information

Name	Description	✅	🔧	💭
`isaacscript/complete-sentences-jsdoc`	Enforces complete sentences for JSDoc comments	✅
`isaacscript/complete-sentences-line-comments`	Enforces complete sentences for multi-line leading line comments	✅
`isaacscript/enum-member-number-separation`	Disallows numbers next to letters in enum members
`isaacscript/eqeqeq-fix`	Requires the use of `===` and `!==` (and automatically fixes)	✅	🔧
`isaacscript/format-jsdoc-comments`	Disallows `/**` comments longer than N characters and multi-line comments that can be merged together	✅	🔧
`isaacscript/format-line-comments`	Disallows `//` comments longer than N characters and multi-line comments that can be merged together	✅	🔧
`isaacscript/no-empty-jsdoc`	Disallows empty JSDoc comments	✅	🔧
`isaacscript/no-explicit-array-loops`	Disallows explicit iteration for arrays	✅	🔧	💭
`isaacscript/no-implicit-map-set-loops`	Disallows implicit iteration for `Maps` and `Sets`	✅	🔧	💭
`isaacscript/no-let-any`	Disallows declaring variables with let that do not have a type	✅		💭
`isaacscript/no-object-any`	Disallows declaring objects and arrays that do not have a type	✅		💭
`isaacscript/no-template-curly-in-string-fix`	Disallows template literal placeholder syntax in regular strings (and automatically fixes)	✅	🔧
`isaacscript/no-useless-return-no-fix`	Disallows redundant return statements (and does not automatically fix)	✅
`isaacscript/no-void-return-type`	Disallows void return types on non-exported functions	✅	🔧

Automatic Fixing

You probably already use Prettier, which is helpful to automatically format files. You probably even have your IDE set up to run Prettier every time your save a file. This kind of thing saves you a tremendous amount of time - you can type out a bunch of code completely unformatted, and then press Ctrl + s at the end to automatically fix everything. (Alternatively, you could press Ctrl + shift + f to format the file without saving it, but it's simpler to just use one hotkey for everything.)

In a similar way to Prettier, this ESLint plugin contains several rules that are designed to automatically apply whenever you save the file (like the format-jsdoc-comments rule). These rules are "fixers", which are applied when ESLint is executed with the "--fix" flag. So, in the same way that you configure Prettier to run on save, you should also configure eslint --fix to run on save.

For example, if you use VSCode, and you have the Prettier and the ESLint extensions installed, you can add the following to your repository's .vscode/settings.json file:

{
  // Automatically run the formatter when certain files are saved.
  "[javascript]": {
    "editor.codeActionsOnSave": ["source.fixAll.eslint"],
    "editor.defaultFormatter": "esbenp.prettier-vscode",
    "editor.formatOnSave": true,
    "editor.tabSize": 2
  },
  "[typescript]": {
    "editor.codeActionsOnSave": ["source.fixAll.eslint"],
    "editor.defaultFormatter": "esbenp.prettier-vscode",
    "editor.formatOnSave": true,
    "editor.tabSize": 2
  }
}

Comment Formatting

For a discussion around comments and the motivations for some of the comment rules in the plugin, see this page.

Contributing

Thanks for helping out with this open-source project!

If you are adding a new rule, start by using the NPM script to automate a few things:

npm run create-rule
git status # Show what the NPM script did

Additionally, You can contact me on Discord if you are doing a PR and have questions.